Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Targets for NET6 and NetStandard 2.1 | Bump packages #404

Closed
wants to merge 4 commits into from

Conversation

jafin
Copy link
Contributor

@jafin jafin commented Jun 12, 2023

  • Add back support for .net6 (current LTS) and .NetStandard 2.1
  • Bump packages
  • Add basic build/test workflow.

NOTE: efCore package excludes.NetStandard 2.1 as it is not compatible with EFCore 7 assemblies.

Resolves #363

SmartEnum.sln Show resolved Hide resolved
@ardalis
Copy link
Owner

ardalis commented Jan 16, 2024

What's the reason for the changes to the build yml file?

@ardalis
Copy link
Owner

ardalis commented Jan 16, 2024

Hmm, unfortunately getting lots of build errors with this

@jafin
Copy link
Contributor Author

jafin commented Jan 16, 2024

@ardalis wow i forgot about this, yeah looks like its out of sync with main. Did you cherry pick bits to get it going or did you want me to correct this PR and remove the build yml stuff?

@ardalis
Copy link
Owner

ardalis commented Jan 17, 2024

I mostly tried to do it myself, which worked for the base package but I'm still fighting with the related packages. Probably it's not worth trying to recover anything from this PR unless you disagree.

@jafin
Copy link
Contributor Author

jafin commented Jan 17, 2024

Yep, if youve done the hard work, lets close this one as outdated/stale

@jafin jafin closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why no longer support for netstandard and previous .net versions?
2 participants